Changeset 43 for abuse/trunk/src/includeTweet

Timestamp:

Mar 2, 2008, 1:58:48 AM (14 years ago)

Author:

Sam Hocevar

Message:

• Fix argument types in lisp_cos(), lisp_sin() and lisp_atan() to avoid overflows. Closes #1 #2 #3.

Location:

abuse/trunk/src/include

Files:

• lisp.hpp (modified) (2 diffs)
• lisp2.hpp (modified) (2 diffs)

abuse/trunk/src/include/lisp.hpp

@@ -21 +21 @@
 
 #define FIXED_TRIG_SIZE 360               // 360 degrees stored in table
-extern long sin_table[FIXED_TRIG_SIZE];   // this should be filled in by external module
+extern int32_t sin_table[FIXED_TRIG_SIZE];   // this should be filled in by external module
 #define TBS 1662                          // atan table granularity
-extern unsigned short atan_table[TBS];
+extern uint16_t atan_table[TBS];
 #define NILP(x) (x==NULL)
 #define DEFINEDP(x) (x!=l_undefined)
@@ -197 +197 @@
 extern int space_size[4];
 void *nth(int num, void *list);
-long lisp_atan2(long dy, long dx);
-long lisp_sin(long x);
-long lisp_cos(long x);
+int32_t lisp_atan2(int32_t dy, int32_t dx);
+int32_t lisp_sin(int32_t x);
+int32_t lisp_cos(int32_t x);
 void restore_heap(void *val, int heap);
 void *mark_heap(int heap);

abuse/trunk/src/include/lisp2.hpp

@@ -62 +62 @@
 
 #define FIXED_TRIG_SIZE 360               // 360 degrees stored in table
-extern long sin_table[FIXED_TRIG_SIZE];   // this should be filled in by external module
+extern int32_t sin_table[FIXED_TRIG_SIZE];   // this should be filled in by external module
 #define TBS 1662                          // atan table granularity
-extern unsigned short atan_table[TBS];
+extern uint16_t atan_table[TBS];
 
 /* ------------------------- COMPATIBILITY -------------------- */
@@ -111 +111 @@
 char* symbol_name (void* symbol);
 int item_type (void* cell);
-long lisp_cos(long x);
-long lisp_sin(long x);
-long lisp_atan2(long dy, long dx);
+int32_t lisp_cos(int32_t x);
+int32_t lisp_sin(int32_t x);
+int32_t lisp_atan2(int32_t dy, int32_t dx);
 void push_onto_list(Cell *object, Cell *&list);