Changeset 30 for abuseTweet

Timestamp:

Mar 1, 2008, 2:58:14 PM (15 years ago)

Author:

Sam Hocevar

Message:

• Fix heap corruption and resulting at-exit crash, thanks to Kees Cook.

File:

• abuse/trunk/src/include/stack.hpp (modified) (2 diffs)

abuse/trunk/src/include/stack.hpp

@@ -15 +15 @@
   T **sdata;
   long son;
+  long smax;
 
-  grow_stack(int max_size) { sdata=(T **)jmalloc(max_size,"pointer stack");  son=0; }
+  grow_stack(int max_size) {
+    smax=max_size;
+    son=0;
+    sdata=(T **)jmalloc(sizeof(T *)*smax,"pointer stack");
+  }
   void push(T *data) 
   {
+    if (son>=smax) { lbreak("stack overflow (%ld)\n",smax); exit(1); }
     sdata[son]=data;
     son++;
@@ -24 +30 @@
    
   T *pop(long total) 
-  { if (total>son) { lbreak("stack underflow\n"); exit(0); }
+  { if (total>son) { lbreak("stack underflow\n"); exit(1); }
     son-=total;
     return sdata[son];